chore(deps): bump @metamask/keyring-api to 6.0.0, @metamask/eth-snap-keyring to 4.0.0 and snap dependencies #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/json-rpc-middleware-stream@6.0.2, npm/@types/deep-freeze-strict@1.1.2, npm/@types/punycode@2.1.4 |
montelaidev
changed the title
|
@metamaskbot publish-preview |
3 tasks
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
danroc
changed the title
danroc
approved these changes
Apr 19, 2024
ccharly
reviewed
Apr 19, 2024
Comment on lines
+802
to
+803
| const internalAccount = this.getAccount(accountId); | ||
| return internalAccount ? internalAccount.metadata[metadataKey] : undefined; |
There was a problem hiding this comment.
Normally getAccount will return either an InternalAccount or undefined so I guess we can use this notation:
Suggested change
| const internalAccount = this.getAccount(accountId); | |
| return internalAccount ? internalAccount.metadata[metadataKey] : undefined; | |
| return internalAccount?.metadata[metadataKey]; |
If you find it less clear, we can keep yours!
| * @returns The value of the specified metadata key, or undefined if the account or metadata key does not exist. | ||
| */ | ||
| #populateExistingMetadata<T extends keyof InternalAccount['metadata']>( | ||
| accountId: string, |
There was a problem hiding this comment.
This could be undefined as well with this expression: existingAccount?.id?
I believe there's always a "previous account" during the update, but in terms of typing this could be undefined (hence the ?)
What about new accounts, they are not used in then updateAccounts methods, right?
| ? existingAccount.metadata.name | ||
| : `${keyringTypeName} ${keyringAccountIndex + 1}`, | ||
| lastSelected: existingAccount?.metadata?.lastSelected, | ||
| this.#populateExistingMetadata(existingAccount?.id, 'name') ?? |
There was a problem hiding this comment.
Related to my other comment that exitstingAccount?.id could be undefined. I guess we can use internalAccount.id here directly, no? This way we know it's not "potentially" undefined?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR bumps the
@metamask/keyring-api,@metamask/eth-snap-keyringand snap dependencies in theAccountsControllerReferences
Resolves: 4135
Changelog
@metamask/accounts-controller@metamask/keyring-apito^6.0.0@metamask/eth-snap-keyringto^4.0.0@metamask/snaps-controllerto^7.0.1@metamask/snaps-sdkto^4.0.1@metamask/snaps-utilsto^7.1.0Checklist