refactor: update Nft Controllers to use selectedAccountId instead of selectedAddress #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
montelaidev
changed the title
montelaidev
force-pushed
the
fix/ap381/update-nft-controllers-to-use-internal-account
branch
from
61ace68
to
dd6e3e8
Compare
montelaidev
force-pushed
the
fix/ap381/update-nft-controllers-to-use-internal-account
branch
from
dd6e3e8
to
42bbf96
Compare
ccharly
reviewed
Jun 5, 2024
ccharly
reviewed
Jun 5, 2024
mcmire
reviewed
Jun 5, 2024
| @@ -314,7 +323,7 @@ export class NftController extends BaseController< | |||
| */ | |||
| constructor({ | |||
| chainId: initialChainId, | |||
| selectedAddress = '', | |||
| selectedAccountId = '', | |||
There was a problem hiding this comment.
Similar comment as here — what are your thoughts on using the messenger to get this value from the AccountsController a bit later on in this constructor instead of having the constructor take this argument?
…controllers-to-use-internal-account
ccharly
reviewed
Jun 6, 2024
ccharly
reviewed
Jun 6, 2024
ccharly
reviewed
Jun 7, 2024
ccharly
reviewed
Jun 7, 2024
ccharly
approved these changes
Jun 7, 2024
ccharly
deleted the
fix/ap381/update-nft-controllers-to-use-internal-account
branch
legobeat
pushed a commit
that referenced
this pull request
Jun 11, 2024
…selectedAddress (#4221) This PR updates removes `selectedAddress` and uses the controller messenger to get InternalAccounts in the Nft Controllers Fixes https://github.com/MetaMask/accounts-planning/issues/381 - **BREAKING**: `NftController` constructor argument `selectedAddress` has been removed. - **BREAKING**: `NftController` now requires `AccountsControlelr:get{Account,SelectedAccount}` messenger actions. - **BREAKING**: `NftController` now requires `AccountsController:selectedEvmAccountChange` event. - **BREAKING**: `NftDetectionController` now requires `AccountsControlelr:getSelectedAccount` messenger actions. - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates removes
selectedAddressand uses the controller messenger to get InternalAccounts in the Nft ControllersReferences
Fixes https://github.com/MetaMask/accounts-planning/issues/381
Changelog
@metamask/assets-controllersNftControllerconstructor argumentselectedAddresshas been removed.NftControllernow requiresAccountsControlelr:get{Account,SelectedAccount}messenger actions.NftControllernow requiresAccountsController:selectedEvmAccountChangeevent.NftDetectionControllernow requiresAccountsControlelr:getSelectedAccountmessenger actions.Checklist