-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lower occurenceFloor for linea mainnet to 1 #4253
Conversation
return parseJsonResponse(response); | ||
const result = await parseJsonResponse(response); | ||
if (Array.isArray(result) && chainId === ChainId['linea-mainnet']) { | ||
return result.filter((elm) => elm.aggregators.includes('lineaTeam')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return result.filter((elm) => elm.aggregators.includes('lineaTeam')); | |
return result.filter((elm) => elm.aggregators.includes('lineaTeam') || elm.aggregators.length >= 3); |
What do you think about this? This still includes 100% of whats in the lineaTeam
list. But continues allowing tokens that made it into 3 sources. Otherwise we could be excluding tokens that used to appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏 for record, added the OR statement to avoid disappearing tokens that used to appear to users before because they were on +3 lists different than lineaTeam
Explanation
Lower occurenceFloor for linea mainnet to only 1 list instead of 3.
Add a filter for lineaTeam aggregator when we fetch token list from token-api when the user is on linea-mainnet.
References
Changelog
@metamask/assets-controllers
lineaTeam
aggregator on the returned list byfetchTokenListByChainId
when the user is on linea mainnet.Checklist