-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate TokensController to BaseControllerV2 #4304
Merged
cryptodev-2s
merged 16 commits into
main
from
feature/migrate-tokens-controller-to-base-controller-v2
May 29, 2024
Merged
feat: migrate TokensController to BaseControllerV2 #4304
cryptodev-2s
merged 16 commits into
main
from
feature/migrate-tokens-controller-to-base-controller-v2
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommasini
reviewed
May 23, 2024
tommasini
reviewed
May 23, 2024
3 tasks
kanthesha
suggested changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I have added some small suggestions.
…s-controller-to-base-controller-v2
kanthesha
suggested changes
May 29, 2024
…s-controller-to-base-controller-v2
kanthesha
previously approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
kanthesha
approved these changes
May 29, 2024
cryptodev-2s
deleted the
feature/migrate-tokens-controller-to-base-controller-v2
branch
May 29, 2024 23:14
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The TokensController has been migrated to BaseControllerV2. As part of this migration, the deprecated config property has been removed and has been replaced with flatten properties on the controller constructor (
chainId
,selectedAddress
andprovider
).PS: A migration is needed when using a new release of this controller.
References
Changelog
@metamask/assets-controllers
Changed
BaseControllerV2
selectedAddress
andprovider
parameters.type
instead ofinterface
and replace thebalanceError
property withhasBalanceError
flag.Checklist