fix: remove value from price api call #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimtb
force-pushed
the
fix-assets-controller-market-data
branch
from
7bfd324
to
92ab226
Compare
sahar-fehri
approved these changes
Jun 4, 2024
7 tasks
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 16, 2024
## **Description** Fixes an issue with erc20 token prices on networks where ETH is not the native currency. When the price API does not support the native currency (e.g. MATIC), prices are fetched in ETH and an additional conversion hop is performed. But the extension was using the raw value without this additional hop. This PR patches the relevant parts of MetaMask/core#4364. Because that change is already in 12.1.0, this patch will no longer be needed in that version. [](https://codespaces.new/MetaMask/metamask-extension/pull/26450?quickstart=1) ## **Related issues** ## **Manual testing steps** 1. Load a wallet on polygon with erc20 tokens 2. Verify fiat prices are correct ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="355" alt="Screenshot 2024-08-15 at 11 19 43 AM" src="https://github.com/user-attachments/assets/f366027e-789e-44e9-99b8-b7a99f24c250"> ### **After** <img width="355" alt="Screenshot 2024-08-15 at 11 15 00 AM" src="https://github.com/user-attachments/assets/59113748-3118-4fbb-bd6e-30c12b64b7fe"> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/26450?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Delete the value property from the returned payload of the tokenRateController
References
Changelog
@metamask/assets-controllerChecklist