Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Wildcard Exports to Named Exports Across Multiple Files #4475

Closed
wants to merge 8 commits into from
13 changes: 13 additions & 0 deletions packages/accounts-controller/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import * as allExports from '.';

describe('@metamask/accounts-controller', () => {
it('has expected JavaScript exports', () => {
expect(Object.keys(allExports)).toMatchInlineSnapshot(`
Array [
"AccountsController",
"keyringTypeToName",
"getUUIDFromAddressOfNormalAccount",
]
`);
});
});
12 changes: 12 additions & 0 deletions packages/address-book-controller/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as allExports from '.';

describe('@metamask/address-book-controller', () => {
it('has expected JavaScript exports', () => {
expect(Object.keys(allExports)).toMatchInlineSnapshot(`
Array [
"getDefaultAddressBookControllerState",
"AddressBookController",
]
`);
});
});
11 changes: 11 additions & 0 deletions packages/announcement-controller/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import * as allExports from '.';

describe('@metamask/announcement-controller', () => {
it('has expected JavaScript exports', () => {
expect(Object.keys(allExports)).toMatchInlineSnapshot(`
Array [
"AnnouncementController",
]
`);
});
});
12 changes: 11 additions & 1 deletion packages/announcement-controller/src/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
export * from './AnnouncementController';
export type {
AnnouncementMap,
StateAnnouncementMap,
AnnouncementControllerState,
AnnouncementControllerActions,
AnnouncementControllerEvents,
AnnouncementControllerGetStateAction,
AnnouncementControllerStateChangeEvent,
AnnouncementControllerMessenger,
} from './AnnouncementController';
export { AnnouncementController } from './AnnouncementController';
19 changes: 19 additions & 0 deletions packages/approval-controller/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import * as allExports from '.';

describe('@metamask/approval-controller', () => {
it('has expected JavaScript exports', () => {
expect(Object.keys(allExports)).toMatchInlineSnapshot(`
Array [
"ORIGIN_METAMASK",
"APPROVAL_TYPE_RESULT_ERROR",
"APPROVAL_TYPE_RESULT_SUCCESS",
"ApprovalController",
"ApprovalRequestNotFoundError",
"ApprovalRequestNoResultSupportError",
"NoApprovalFlowsError",
"EndInvalidFlowError",
"MissingApprovalFlowError",
]
`);
});
});
54 changes: 52 additions & 2 deletions packages/approval-controller/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,52 @@
export * from './ApprovalController';
export * from './errors';
export {
ORIGIN_METAMASK,
APPROVAL_TYPE_RESULT_ERROR,
APPROVAL_TYPE_RESULT_SUCCESS,
ApprovalController,
} from './ApprovalController';

export type {
ApprovalRequest,
ApprovalFlowState,
ApprovalControllerState,
ApprovalControllerMessenger,
ShowApprovalRequest,
ResultComponent,
ApprovalControllerOptions,
AddApprovalOptions,
UpdateRequestStateOptions,
AcceptOptions,
StartFlowOptions,
EndFlowOptions,
SetFlowLoadingTextOptions,
SuccessOptions,
ErrorOptions,
AcceptResultCallbacks,
AddResult,
AcceptResult,
ApprovalFlowStartResult,
SuccessResult,
ErrorResult,
ApprovalStateChange,
ApprovalControllerEvents,
GetApprovalsState,
ClearApprovalRequests,
AddApprovalRequest,
HasApprovalRequest,
AcceptRequest,
RejectRequest,
UpdateRequestState,
StartFlow,
EndFlow,
SetFlowLoadingText,
ShowSuccess,
ShowError,
} from './ApprovalController';

export {
ApprovalRequestNotFoundError,
ApprovalRequestNoResultSupportError,
NoApprovalFlowsError,
EndInvalidFlowError,
MissingApprovalFlowError,
} from './errors';
32 changes: 32 additions & 0 deletions packages/assets-controllers/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import * as allExports from '.';

describe('@metamask/assets-controllers', () => {
it('has expected JavaScript exports', () => {
expect(Object.keys(allExports)).toMatchInlineSnapshot(`
Array [
"AccountTrackerController",
"SINGLE_CALL_BALANCES_ADDRESS_BY_CHAINID",
"MISSING_PROVIDER_ERROR",
"AssetsContractController",
"CurrencyRateController",
"getDefaultNftControllerState",
"NftController",
"NftDetectionController",
"TokenBalancesController",
"TokenDetectionController",
"TokenListController",
"getDefaultTokenRatesControllerState",
"TokenRatesController",
"TokensController",
"isTokenDetectionSupportedForNetwork",
"formatIconUrlWithProxy",
"getFormattedIpfsUrl",
"fetchTokenContractExchangeRates",
"CodefiTokenPricesServiceV2",
"SUPPORTED_CHAIN_IDS",
"RatesController",
"Cryptocurrency",
]
`);
});
});
19 changes: 17 additions & 2 deletions packages/assets-controllers/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,23 @@ export type {
AccountTrackerControllerEvents,
} from './AccountTrackerController';
export { AccountTrackerController } from './AccountTrackerController';
export * from './AssetsContractController';
export * from './CurrencyRateController';
export type {
AssetsContractConfig,
BalanceMap,
} from './AssetsContractController';
export {
SINGLE_CALL_BALANCES_ADDRESS_BY_CHAINID,
MISSING_PROVIDER_ERROR,
AssetsContractController,
} from './AssetsContractController';
export type {
CurrencyRateState,
CurrencyRateStateChange,
CurrencyRateControllerEvents,
GetCurrencyRateState,
CurrencyRateControllerActions,
} from './CurrencyRateController';
export { CurrencyRateController } from './CurrencyRateController';
export type {
NftControllerState,
NftControllerMessenger,
Expand Down
Loading