Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public name property to AssetsContractController class #4564

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Jul 26, 2024

References

Changelog

### Added

- Add public readonly property `name` to `AssetsContractController` and assign "AssetsContractController" as its value.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift MajorLift self-assigned this Jul 26, 2024
@MajorLift MajorLift requested a review from a team as a code owner July 26, 2024 19:35
@MajorLift
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-aaea6b5",
  "@metamask-previews/address-book-controller": "5.0.0-preview-aaea6b5",
  "@metamask-previews/announcement-controller": "7.0.0-preview-aaea6b5",
  "@metamask-previews/approval-controller": "7.0.2-preview-aaea6b5",
  "@metamask-previews/assets-controllers": "37.0.0-preview-aaea6b5",
  "@metamask-previews/base-controller": "6.0.2-preview-aaea6b5",
  "@metamask-previews/build-utils": "3.0.0-preview-aaea6b5",
  "@metamask-previews/chain-controller": "0.1.1-preview-aaea6b5",
  "@metamask-previews/composable-controller": "7.0.0-preview-aaea6b5",
  "@metamask-previews/controller-utils": "11.0.2-preview-aaea6b5",
  "@metamask-previews/ens-controller": "13.0.1-preview-aaea6b5",
  "@metamask-previews/eth-json-rpc-provider": "4.1.2-preview-aaea6b5",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-aaea6b5",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-aaea6b5",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-aaea6b5",
  "@metamask-previews/keyring-controller": "17.1.2-preview-aaea6b5",
  "@metamask-previews/logging-controller": "5.0.0-preview-aaea6b5",
  "@metamask-previews/message-manager": "10.0.2-preview-aaea6b5",
  "@metamask-previews/name-controller": "8.0.0-preview-aaea6b5",
  "@metamask-previews/network-controller": "20.1.0-preview-aaea6b5",
  "@metamask-previews/notification-controller": "6.0.0-preview-aaea6b5",
  "@metamask-previews/notification-services-controller": "0.2.0-preview-aaea6b5",
  "@metamask-previews/permission-controller": "11.0.0-preview-aaea6b5",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-aaea6b5",
  "@metamask-previews/phishing-controller": "10.1.1-preview-aaea6b5",
  "@metamask-previews/polling-controller": "9.0.1-preview-aaea6b5",
  "@metamask-previews/preferences-controller": "13.0.1-preview-aaea6b5",
  "@metamask-previews/profile-sync-controller": "0.2.0-preview-aaea6b5",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-aaea6b5",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-aaea6b5",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-aaea6b5",
  "@metamask-previews/signature-controller": "18.0.1-preview-aaea6b5",
  "@metamask-previews/transaction-controller": "35.1.0-preview-aaea6b5",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-aaea6b5"
}

@MajorLift MajorLift requested a review from a team July 29, 2024 13:39
@MajorLift MajorLift merged commit 4398a99 into main Jul 30, 2024
116 checks passed
@MajorLift MajorLift deleted the add-name-property-to-AssetsContractController branch July 30, 2024 16:41
AugmentedMode pushed a commit that referenced this pull request Jul 30, 2024
## References

- See #4072

## Changelog

```md
### Added

- Add public readonly property `name` to `AssetsContractController` and assign "AssetsContractController" as its value.
```

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert AssetsContractController from BaseControllerV1 to BaseControllerV2
2 participants