-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix RatesController.setCryptoCurrencyList invalid internal field #4572
fix: fix RatesController.setCryptoCurrencyList invalid internal field #4572
Conversation
@metamaskbot publish-previews |
@ccharly maybe we should add a unit test to catch that, the fact that it was passing before shows that the test was lacking |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
50a1dd8
to
31fdc1d
Compare
31fdc1d
to
9be3b6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM. Thanks for correcting my mistake
Explanation
We missed to rename that field in that PR: #4242
References
N/A
Changelog
@metamask/assets-controllers
RatesController.setCryptocurrencyList
fromCurrencies
->cryptocurrencies
)Checklist