Bump typescript from ~5.0.4 to ~5.1.6
#4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/typescript@5.0.4 |
MajorLift
changed the title
typescript from ~5.0.4 to ~5.1.6
MajorLift
force-pushed
the
bump-typescript-to-5.1
branch
2 times, most recently
from
400fcca
to
703d3c4
Compare
matthewwalsh0
approved these changes
Aug 1, 2024
FrederikBolding
approved these changes
Aug 1, 2024
MajorLift
commented
Aug 1, 2024
Comment on lines
+167
to
+175
| const implementation = this.implementations[type].method as ( | ||
| ...args: Parameters<RateLimitedApis[ApiType]['method']> | ||
| ) => ReturnType<RateLimitedApis[ApiType]['method']>; | ||
|
|
||
| if (!implementation) { | ||
| throw new Error('Invalid api type'); | ||
| } | ||
|
|
||
| return implementation(...args) as ReturnType< | ||
| RateLimitedApis[ApiType]['method'] | ||
| >; | ||
| return implementation(...args); |
There was a problem hiding this comment.
@MetaMask/snaps-devs This change fixes the following regression:
ERROR: src/RateLimitController.ts:173:27 - error TS2345: Argument of type 'Parameters<RateLimitedApis[ApiType]["method"]>' is not assignable to parameter of type 'never'.
Type 'unknown[]' is not assignable to type 'never'.
Type 'Parameters<RateLimitedApis[keyof RateLimitedApis]["method"]>' is not assignable to type 'never'.
Type 'unknown[]' is not assignable to type 'never'.
Type 'Parameters<RateLimitedApis[string | number | symbol]["method"]>' is not assignable to type 'never'.
Type 'unknown[]' is not assignable to type 'never'.
Type 'Parameters<RateLimitedApis[string]["method"]> | Parameters<RateLimitedApis[number]["method"]> | Parameters<RateLimitedApis[symbol]["method"]>' is not assignable to type 'never'.
Type 'Parameters<RateLimitedApis[string]["method"]>' is not assignable to type 'never'.
Type 'unknown[]' is not assignable to type 'never'.
Type 'never[]' is not assignable to type 'never'.
173 return implementation(...args) as ReturnType<Both before and after the change, the as assertion narrows the type of implementation, which is currently typed to the universal supertype (i.e. type constraint) of all RateLimitedApi method types (i.e. ActionConstraint) because there's no ApiType information to narrow it.
The only difference is that the type assertion now narrows the parameters (...args) of implementation, in addition to its return type.
cryptotavares
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Changelog
Checklist