Release 193.0.0 #4643
Merged
Release 193.0.0 #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/logging-controller@5.0.0) |
|
@metamaskbot publish-preview |
MajorLift
commented
Aug 28, 2024
Comment on lines
+19
to
+20
| - **BREAKING:** Fix `StateMetadata` type so that it requires associated metadata for all optional and non-optional top-level state properties ([#4612](https://github.com/MetaMask/core/pull/4612)) | ||
| - Fixes issue of runtime error being thrown during `BaseController` instantiation due to missing metadata for optional state properties. |
There was a problem hiding this comment.
I'm not sure if we should count this as a breaking change, even though the StateMetadata type has been narrowed.
(∵ T & Required<U> extends T & U extends T & Partial<U> extends T)
@kanthesha @Gudahtt Thoughts? Could we make this a minor release?
3 tasks
Mrtenz
previously approved these changes
Aug 28, 2024
jpuri
previously approved these changes
Aug 28, 2024
AugmentedMode
previously approved these changes
Aug 29, 2024
MajorLift
dismissed
AugmentedMode’s stale review
The merge-base changed after approval.
AugmentedMode
previously approved these changes
Aug 29, 2024
MajorLift
dismissed
AugmentedMode’s stale review
The merge-base changed after approval.
MajorLift
force-pushed
the
release/193.0.0
branch
from
fcfc3cf
to
f6acf55
Compare
imblue-dabadee
previously approved these changes
Aug 29, 2024
AugmentedMode
previously approved these changes
Aug 29, 2024
MajorLift
commented
Aug 29, 2024
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
AugmentedMode
dismissed stale reviews from imblue-dabadee and themself
via
ea4443c
jpuri
approved these changes
Aug 29, 2024
FrederikBolding
approved these changes
Aug 29, 2024
Mrtenz
approved these changes
Aug 29, 2024
MajorLift
commented
Aug 29, 2024
Comment on lines
+12
to
+16
| ### Added | ||
|
|
||
| - Add `getHostnameFromUrl` utility function to standardize hostname extraction from URLs ([#4645](https://github.com/MetaMask/core/pull/4645)) | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
Missed this entry. Leaving it here so we can backport it into the changelog in a future commit. @MetaMask/product-safety
Suggested change
| ### Added | |
| - Add `getHostnameFromUrl` utility function to standardize hostname extraction from URLs ([#4645](https://github.com/MetaMask/core/pull/4645)) | |
| ### Fixed | |
| ### Added | |
| - Add `getHostnameFromUrl` utility function to standardize hostname extraction from URLs ([#4645](https://github.com/MetaMask/core/pull/4645)) | |
| ### Changed | |
| - Bump `@metamask/base-controller` from `^6.0.3` to `^7.0.0` ([#4643](https://github.com/MetaMask/core/pull/4643)) | |
| ### Fixed |
Prithpal-Sooriya
added a commit
that referenced
this pull request
Sep 5, 2024
## Explanation This is a release candidate for v195.0.0. - `@metamask/profile-sync-controller@0.3.0` - `@metamask/notification-services-controller@0.3.0` <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> ## Changelog ```md ### Changed - Bump `@metamask/profile-sync-controller` from `^0.2.1` to `^0.3.0` ([#4643](#4657)) - Bump `@metamask/notification-services-controller` from `^0.2.1` to `^0.3.0` ([#4643](#4657)) ``` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This is a release candidate for v193.0.0.
@metamask/approval-controller@7.0.3(patch)@metamask/base-controller@7.0.0(major)@metamask/composable-controller@9.0.0(major)@metamask/keyring-controller@17.2.0(minor)@metamask/logging-controller@6.0.0(major)@metamask/message-manager@10.0.3(patch)@metamask/phishing-controller@12.0.1(patch)@metamask/signature-controller@19.0.0(major)Changelog
Checklist