Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 202.0.0 #4688

Closed
wants to merge 10 commits into from
Closed

Release 202.0.0 #4688

wants to merge 10 commits into from

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Sep 11, 2024 •
edited
Loading

Explanation

This PR is release candidate for v202.0.0

Changelog

Changes

  • Bumped @metamask/controller-utils to ^11.3.0 for following packages

    • @metamask/address-book-controller
    • @metamask/assets-controller
    • @metamask/ens-controller
    • @metamask/gas-fee-controller
    • @metamask/logging-controller
    • @metamask/message-manager
    • @metamask/name-controller
    • @metamask/network-controller
    • @metamask/notification-services-controller
    • @metamask/permissions-controller
    • @metamask/polling-controller
    • @metamask/preferences-controller
    • @metamask/polling-controller
    • @metamask/queued-request-controller
    • @metamask/user-operation-controller
    • @metamask/transaction-controller
    • @metamask/signature-controller

  • Changes for @metamask/transaction-controller

    • Removed trace types from TransactionController, instead import them from @metamask/controller-utils (#4655)

  • Changes for @metamask/signature-controller

    • Add tracing infrastructure (#4575)
    • Add optional trace callback to constructor.
    • Add optional traceContext option to newUnsignedPersonalMessage and newUnsignedTypedMessage methods.
    • Add initial tracing of signature lifecycle.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz OGPoyraz requested review from a team as code owners September 11, 2024 14:01
MajorLift
MajorLift reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added entries for controller-utils bumps.

It would also be nice to note the controller-utils bump in the PR description. It would be very helpful to future changelog writers releasing packages that updated their controller-utils versions in this pr but were not part of this release.

packages/signature-controller/CHANGELOG.md Show resolved Hide resolved
packages/transaction-controller/CHANGELOG.md Show resolved Hide resolved
@MajorLift
Copy link
Contributor

Looks like the lockfile needs an update. Otherwise LGTM!

@bergeron bergeron mentioned this pull request Sep 12, 2024
Merged
7 tasks
@OGPoyraz
Copy link
Member Author

Thanks a lot for your input @MajorLift

OGPoyraz and others added 2 commits September 13, 2024 09:25
@OGPoyraz @MajorLift
Update packages/signature-controller/CHANGELOG.md
38db9f5 
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@OGPoyraz @MajorLift
Update packages/transaction-controller/CHANGELOG.md
afec6d7 
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@OGPoyraz @MajorLift
Update packages/transaction-controller/CHANGELOG.md
3c1bbec 
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@MajorLift
Copy link
Contributor

MajorLift commented Sep 13, 2024 •
edited
Loading

The controller-utils bump entry in the signature-controller changelog also needs to be restored. You might need to refresh the page to see the updates in this thread above.

matthewwalsh0
matthewwalsh0 requested changes Sep 14, 2024
View reviewed changes
packages/transaction-controller/CHANGELOG.md

### Changed

- Bump `@metamask/controller-utils` from `^11.2.0` to `^11.3.0` ([#4688](https://github.com/MetaMask/core/pull/4688))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the hassle, but we'll need to add the change log entries for the startup fixes also, thanks!

#4658

Mrtenz
Mrtenz requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do a release of all packages now that #4648 is merged. Happy to recreate this PR for you.

@OGPoyraz
Copy link
Member Author

We decided to close this and create new one with @Mrtenz

@OGPoyraz OGPoyraz closed this Sep 16, 2024
@Mrtenz Mrtenz deleted the release/202.0.0 branch September 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 requested changes

@Mrtenz Mrtenz Mrtenz requested changes

@MajorLift MajorLift MajorLift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OGPoyraz @MajorLift @Mrtenz @matthewwalsh0