Add support for unicode domans to PhishingController #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PhishingController now supports unicode domains. Previously it supported plain ASCII domains (including punycode domains), but any domains with non-ASCII unicode characters would always be considered as safe. Tests have been added to ensure the `test` and `bypass` methods both normalize input to punycode. Note that any whitelisted unicode domains will now be ignored. We could fix this with a migration, but it's exceedingly unlikely that any unicode domains could have been whitelisted in the first place, because we only offer that ability for blocked domains. And unicode domains were never blocked. The `eth-phishing-detect` package was updated to make a pre-existing test work correctly. Previously the "should bypass a given domain" test was broken because the example unsafe domain was not blocked in the version of `eth-phishing-detect` used. It is blocked in the current version, and an assertion has been added to ensure these tests are working correctly.
Gudahtt
force-pushed
the
phishing-detector-punycode
branch
from
e0d7aa6
to
6decd8e
Compare
Gudahtt
added a commit
that referenced
this pull request
May 20, 2021
The PhishingController now supports unicode domains. Previously it supported plain ASCII domains (including punycode domains), but any domains with non-ASCII unicode characters would always be considered as safe. Tests have been added to ensure the `test` and `bypass` methods both normalize input to punycode. Note that any whitelisted unicode domains will now be ignored. We could fix this with a migration, but it's exceedingly unlikely that any unicode domains could have been whitelisted in the first place, because we only offer that ability for blocked domains. And unicode domains were never blocked. The `eth-phishing-detect` package was updated to make a pre-existing test work correctly. Previously the "should bypass a given domain" test was broken because the example unsafe domain was not blocked in the version of `eth-phishing-detect` used. It is blocked in the current version, and an assertion has been added to ensure these tests are working correctly.
Gudahtt
added a commit
that referenced
this pull request
May 20, 2021
The PhishingController now supports unicode domains. Previously it supported plain ASCII domains (including punycode domains), but any domains with non-ASCII unicode characters would always be considered as safe. Tests have been added to ensure the `test` and `bypass` methods both normalize input to punycode. Note that any whitelisted unicode domains will now be ignored. We could fix this with a migration, but it's exceedingly unlikely that any unicode domains could have been whitelisted in the first place, because we only offer that ability for blocked domains. And unicode domains were never blocked. The `eth-phishing-detect` package was updated to make a pre-existing test work correctly. Previously the "should bypass a given domain" test was broken because the example unsafe domain was not blocked in the version of `eth-phishing-detect` used. It is blocked in the current version, and an assertion has been added to ensure these tests are working correctly.
Closed
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The PhishingController now supports unicode domains. Previously it supported plain ASCII domains (including punycode domains), but any domains with non-ASCII unicode characters would always be considered as safe. Tests have been added to ensure the `test` and `bypass` methods both normalize input to punycode. Note that any whitelisted unicode domains will now be ignored. We could fix this with a migration, but it's exceedingly unlikely that any unicode domains could have been whitelisted in the first place, because we only offer that ability for blocked domains. And unicode domains were never blocked. The `eth-phishing-detect` package was updated to make a pre-existing test work correctly. Previously the "should bypass a given domain" test was broken because the example unsafe domain was not blocked in the version of `eth-phishing-detect` used. It is blocked in the current version, and an assertion has been added to ensure these tests are working correctly.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The PhishingController now supports unicode domains. Previously it supported plain ASCII domains (including punycode domains), but any domains with non-ASCII unicode characters would always be considered as safe. Tests have been added to ensure the `test` and `bypass` methods both normalize input to punycode. Note that any whitelisted unicode domains will now be ignored. We could fix this with a migration, but it's exceedingly unlikely that any unicode domains could have been whitelisted in the first place, because we only offer that ability for blocked domains. And unicode domains were never blocked. The `eth-phishing-detect` package was updated to make a pre-existing test work correctly. Previously the "should bypass a given domain" test was broken because the example unsafe domain was not blocked in the version of `eth-phishing-detect` used. It is blocked in the current version, and an assertion has been added to ensure these tests are working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PhishingController now supports unicode domains. Previously it supported plain ASCII domains (including punycode domains), but any domains with non-ASCII unicode characters would always be considered as safe.
Tests have been added to ensure the
testandbypassmethods both normalize input to punycode.Note that any whitelisted unicode domains will now be ignored. We could fix this with a migration, but it's exceedingly unlikely that any unicode domains could have been whitelisted in the first place, because we only offer that ability for blocked domains. And unicode domains were never blocked.
The
eth-phishing-detectpackage was updated to make a pre-existing test work correctly. Previously the "should bypass a given domain" test was broken because the example unsafe domain was not blocked in the version ofeth-phishing-detectused. It is blocked in the current version, and an assertion has been added to ensure these tests are working correctly.