Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NOTIFY-1128): add batch PUT endpoint support #4723

Merged
merged 3 commits into from
Sep 23, 2024
Merged

feat(NOTIFY-1128): add batch PUT endpoint support #4723

merged 3 commits into from
Sep 23, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Sep 23, 2024 •
edited
Loading

Explanation

This PR adds support for the new batch PUT endpoint.

References

NOTIFY-1128

Changelog

@metamask/profile-sync-controller

  • ADDED: batch PUT endpoint support for both SDK and controllers

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu marked this pull request as ready for review September 23, 2024 08:13
@mathieuartu mathieuartu requested a review from a team as a code owner September 23, 2024 08:13
Prithpal-Sooriya
Prithpal-Sooriya approved these changes Sep 23, 2024
View reviewed changes
packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

public async performBatchSetStorage(
path: UserStoragePathWithFeatureOnly,
values: [UserStoragePathWithKeyOnly, string][],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool tuple!

Was wondering if this could be an obj, but works fine as is.

@mathieuartu mathieuartu merged commit ea44c16 into main Sep 23, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/add_batch_upsert_support branch September 23, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieuartu @Prithpal-Sooriya