Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 220.0.0 #4798

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Release 220.0.0 #4798

merged 7 commits into from
Oct 16, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 15, 2024

Explanation

References

Contents:

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@legobeat legobeat force-pushed the release/220.0.0 branch 2 times, most recently from 5909d39 to be2ac33 Compare October 15, 2024 23:58
@legobeat legobeat marked this pull request as ready for review October 16, 2024 00:00
@legobeat legobeat requested review from a team as code owners October 16, 2024 00:00
@legobeat
Copy link
Contributor Author

Looking at what comes next in terms of downstream updates, I think it would also be good to get @metamask/eth-json-rpc-provider in there:

@legobeat

This comment was marked as outdated.

@legobeat legobeat force-pushed the release/220.0.0 branch 2 times, most recently from b1e619e to bf3ff1c Compare October 16, 2024 09:17
@legobeat legobeat marked this pull request as ready for review October 16, 2024 09:21
@legobeat legobeat requested a review from a team as a code owner October 16, 2024 09:21
@OGPoyraz
Copy link
Member

OGPoyraz commented Oct 16, 2024

This one is a bit urgent #4739, can we include transaction-controller in to this release?

@legobeat
Copy link
Contributor Author

legobeat commented Oct 16, 2024

This one is a bit urgent #4739, can we include transaction-controller in to this release?

I think it will make things a lot less messy if this can be released without including packages still transitively depending on old @metamask/json-rpc-engine versions in order to not introduce dependency inconsistencies within a package. After that, other packages should be releasable even without first merging the entirety of #4769, which depends on resolving those intermediaries.

If you think we can sort it out and that a single release is preferred, feel free to make a PR targeting this with the necessary changes, though.

@legobeat legobeat merged commit c0e7783 into main Oct 16, 2024
116 checks passed
@legobeat legobeat deleted the release/220.0.0 branch October 16, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants