Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add well formed eip155 reference value check to multichain package #4945

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Nov 19, 2024

Explanation

Fixes bug where 0 prefixed and e exponent suffixed eip155 references were allowed. This PR adds eip155 reference validation against regex.

I'm unsure if this belongs in validation checks, or the supported checks. Validation checks currently do not check for ecosystem specific constraints

References

Changelog

Package has not been released yet. No changelog necessary

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jiexi jiexi requested a review from a team as a code owner November 19, 2024 22:30
@jiexi jiexi changed the title add CaipReferenceRegexes and use in isSupportedScopeString feat: add well formed eip155 reference value checks to multichain package Nov 19, 2024
@jiexi jiexi changed the title feat: add well formed eip155 reference value checks to multichain package feat: add well formed eip155 reference value check to multichain package Nov 19, 2024
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 enabled auto-merge (squash) November 19, 2024 22:42
@adonesky1 adonesky1 merged commit e1243a1 into main Nov 19, 2024
120 checks passed
@adonesky1 adonesky1 deleted the jl/caip-multichain/add-eip155-reference-regex-2 branch November 19, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants