16.0.0 #596
Merged
16.0.0 #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
release/16.0.0
branch
from
9307f2f
to
46babe8
Compare
Closed
Gudahtt
reviewed
Sep 16, 2021
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Sep 16, 2021
CHANGELOG.md
Outdated
| - **BREAKING**: Remove `syncTokens` method from the TokenListController ([#590](https://github.com/MetaMask/controllers/pull/590)) | ||
| - This is breaking for any consumers of this method. | ||
| - Enable default caching for token-service ([#594](https://github.com/MetaMask/controllers/pull/594)) | ||
| - Set tokenList to empty object in test networks ([#588](https://github.com/MetaMask/controllers/pull/588)) |
There was a problem hiding this comment.
This seems to be describing something internal - it doesn't make clear what the actual change was for consumers. It's not clear to me either from reading the PR.
My best guess is that this is a bug fix, and that the change was to clear the dynamic token list when switching to a network not supported by our token list API. Does that sound correct? cc @NiranjanaBinoy @danjm
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
adonesky1
force-pushed
the
release/16.0.0
branch
from
fde5342
to
01f8c96
Compare
|
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 16.0.0 * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * update changelog Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 16.0.0 * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * update changelog Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a release candidate for v.16.0.0
[16.0.0]
Changed
Fixed