-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: ERC1155 support #615
Conversation
Could you add a description for these changes? |
Hey @Gudahtt! Yes! I just found out some testing updates, I will fix that and update the PR for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments and clarifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few questions! Great work though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a few tiny nits and then looks good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Enhancement to support ERC1155 collectible standard by adding the smart contract ABI.
Enhancement to support ERC1155 collectible standard by adding the smart contract ABI.
Description
Currently we don't support the collectible standard ERC-1155, the focus of this development is to integrated the ERC-1155 ABI to access the appropriate methods of the smart contract.
Breaking Changes
CollectiblesController
will have to update the creation parameters and initialization of the object created. The parameters are:To Do
Next Steps