Add preference to enable/disable collectible detection #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
add-collectible-detection-preference
branch
from
c02a0ff
to
e352ad3
Compare
adonesky1
changed the title
wachunei
approved these changes
Nov 23, 2021
This was referenced Nov 24, 2021
Merged
Add and hook up setting to toggle on/off collectible autodetection
MetaMask/metamask-extension#12839
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add preference to enable/disable collectible detection * update tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add preference to enable/disable collectible detection * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the security/UX prerequisites for bringing NFTs into the extension (and for enhancing security for in mobile) we are adding a user preference to allow users to toggle on or off collectible auto-detection, just as we have previously done with ERC-20 Token detection.
NFT in Extension designs:
This PR adds the preference to the PreferencesController and reads that setting in the CollectibleDetectionController to determine whether to detect/poll for collectibles.