Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.0.0 #671

Merged
merged 3 commits into from
Jan 5, 2022
Merged

24.0.0 #671

merged 3 commits into from
Jan 5, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 5, 2022 •
edited by adonesky1
Loading

This is the release candidate for version 24.0.0.

[24.0.0]

Added

  • Breaking Adds checkAndUpdateSingleCollectibleOwnershipStatus method and changes method previously named checkAndUpdateCollectibleOwnershipStatus to checkAndUpdateAllCollectibleOwnershipStatus (#669)
    • Previously incorrectly released as minor version bump 23.1.0.
    • Consumers who consumed checkAndUpdateCollectibleOwnershipStatus must update it's name to checkAndUpdateAllCollectibleOwnershipStatus.

github-actions and others added 2 commits January 5, 2022 14:14
@adonesky1 adonesky1 requested a review from Gudahtt January 5, 2022 14:24
@adonesky1 adonesky1 marked this pull request as ready for review January 5, 2022 14:24
@adonesky1 adonesky1 requested a review from a team as a code owner January 5, 2022 14:24
Gudahtt
Gudahtt reviewed Jan 5, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@adonesky1 @Gudahtt
Update CHANGELOG.md
e1c5983 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@adonesky1 adonesky1 requested a review from Gudahtt January 5, 2022 14:40
Gudahtt
Gudahtt approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit b048670 into main Jan 5, 2022
@Gudahtt Gudahtt deleted the release/24.0.0 branch January 5, 2022 14:46
@Gudahtt
Copy link
Member

Gudahtt commented Jan 5, 2022

This has been published, and v23.1.0 has been marked as deprecated on npm

A new version of the package @metamask/controllers (24.0.0) was published at 2022-01-05T14:48:29.902Z from
[redacted]. The shasum of this package was 380d4e10bd9b903afc38b041ea7e64b30ae34dab.

MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@github-actions @adonesky1
@Gudahtt @MajorLift
24.0.0 (#671)
c80ca76 
* 24.0.0

* update changelog

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Alex <adonesky@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@github-actions @adonesky1
@Gudahtt @MajorLift
24.0.0 (#671)
d1b0fbd 
* 24.0.0

* update changelog

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Alex <adonesky@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @adonesky1