Fix race condition where some token detections can get mistakenly added to the wrong account #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
fix-misattributed-token-detection
branch
from
bd8ff11
to
5ab45c6
Compare
8 tasks
|
Added DO-NOT-MERGE lable until freeze on |
darkwing
reviewed
Nov 14, 2022
darkwing
previously approved these changes
Nov 15, 2022
|
|
adonesky1
dismissed stale reviews from darkwing and NiranjanaBinoy
via
d9347f4
adonesky1
force-pushed
the
fix-misattributed-token-detection
branch
from
dadcc12
to
d9347f4
Compare
…ed to the wrong account
adonesky1
force-pushed
the
fix-misattributed-token-detection
branch
from
d9347f4
to
a471da5
Compare
adonesky1
commented
Nov 16, 2022
segun
approved these changes
Nov 17, 2022
|
The code freeze is over, so the |
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
…ed to the wrong account (#956) Fix race condition causing misattribution for token-detection across networks and accounts
4 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ed to the wrong account (#956) Fix race condition causing misattribution for token-detection across networks and accounts
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ed to the wrong account (#956) Fix race condition causing misattribution for token-detection across networks and accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there exists an issue (exposed by this bug) where if a user changes accounts (account
xto accounty) or (changes from networkato networkb) right as adetectTokens()call is occuring, the results of thegetBalancesInSingleCall()call (withindetectTokens()) made against addressxornetworkacan get incorrectly misattributed to accountyornetworkb. This can happen because currentlydetectTokens()simply callsthis.addDetectedTokens()on theTokensControllerwith the detectedtokensToAddassuming that when this call occurs in theTokensControllertheselectedAddressorchainIdused to store these detected assets will be the same as the one used to detect them. With sufficiently unfortunate timing this expectation can be broken, and so this PR introduces a pattern (already used in the analogous flow between the NftDetectionController and the NftController, whereby the address and network data are passed along with the detectedToken data to ensure they are stored correctly.Partially fixes: MetaMask/metamask-extension#16349
Checklist