Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type resolve-value #41

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Type resolve-value #41

merged 2 commits into from
Mar 15, 2022

Commits on Mar 15, 2022

  1. Type Promise its resolve-value 

    Easier if you want to do:

const provider = await detectEthereumProvider();
provider.on('whenever', whatever);
    @rubenswieringa
    rubenswieringa committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    2969f2c View commit details
    Browse the repository at this point in the history

  2. Add generic type for resolve-value 

    If used in a codebase where an ethereum-provider is expected that doesn’t have an on() method and instead has a different API.
    @rubenswieringa
    rubenswieringa committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    11135b9 View commit details
    Browse the repository at this point in the history