Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: eslint@8.27.0->8.45.0 #310

Merged
merged 4 commits into from
Jul 19, 2023
Merged

devDeps: eslint@8.27.0->8.45.0 #310

merged 4 commits into from
Jul 19, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 18, 2023 •
edited
Loading

  • devDeps: bump eslint to latest version
    • keep peerDeps of eslint unchanged
  • remove now unnecessary patch of eslint to get recommended rules

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 18, 2023
@socket-security
Copy link

socket-security bot commented Jul 18, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@eslint/js 8.45.0 None +0 16.5 kB eslintbot

🚮 Removed packages: @types/jest@29.5.2

@legobeat legobeat marked this pull request as ready for review July 18, 2023 04:04
@legobeat legobeat requested a review from a team as a code owner July 18, 2023 04:04
mcmire
mcmire previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like just ESLint is being updated in this PR, not Jest (you might have taken care of that in a previous PR). Is that intended, and if so, do you want to update the PR title/description?

In any case, this looks good! Nice that we can get rid of that patch file.

@legobeat legobeat changed the title devDeps: bump eslint, jest devDeps: eslint@8.27.0->8.45.0 Jul 19, 2023
@legobeat
Copy link
Contributor Author

It looks like just ESLint is being updated in this PR, not Jest (you might have taken care of that in a previous PR). Is that intended, and if so, do you want to update the PR title/description?

In any case, this looks good! Nice that we can get rid of that patch file.

Indeed! #305

Done. Also bumped to 8.45.0, which was recently released.

@legobeat legobeat requested review from mcmire and a team July 19, 2023 00:14
@legobeat legobeat merged commit 860d5ec into MetaMask:main Jul 19, 2023
@legobeat legobeat deleted the devDeps-eslint-jest branch July 19, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire