-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Jest with Vitest #372
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/glob@7.2.3 Not used in production, though we should look into this. @SocketSecurity ignore npm/wrappy@1.0.2 New author is ok. @SocketSecurity ignore npm/esbuild@0.21.5 Network and shell access is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ESLint 9 has first class support for ESM, and I'm planning to migrate to ESM in #370. Unfortunately Jest doesn't support ESM out of the box, and it's hard to configure properly to support it. Vitest supports ESM natively, without any configuration.
The test files are mostly the same, with the only differences being that they are now ESM, and
describe
,it
,expect
must be explicitly imported.This is a prerequisite for #370.