Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.0 #111

Merged
merged 4 commits into from
Aug 22, 2022
Merged

6.0.0 #111

merged 4 commits into from
Aug 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 6.0.0.

github-actions and others added 2 commits August 16, 2022 20:45
@mcmire mcmire marked this pull request as ready for review August 16, 2022 21:07
@mcmire mcmire requested a review from a team as a code owner August 16, 2022 21:07
@mcmire mcmire mentioned this pull request Aug 16, 2022
Merged
6 tasks
Gudahtt
Gudahtt previously approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
Copy link
Contributor

mcmire commented Aug 16, 2022 •
edited
Loading

Going to add logging before merging this. The version won't change, so I'll leave this open in the meantime I'll move this back to draft in the meantime.

@mcmire mcmire marked this pull request as draft August 16, 2022 22:23
@mcmire
Copy link
Contributor

mcmire commented Aug 17, 2022

Added a couple of logging functions to @metamask/utils. We should be able to use them in this project once this is merged: MetaMask/utils#20

@mcmire
Copy link
Contributor

mcmire commented Aug 19, 2022

Blocked on release of @metamask/utils 3.0.0 which includes the above change.

@mcmire mcmire marked this pull request as ready for review August 22, 2022 22:11
@mcmire
Copy link
Contributor

mcmire commented Aug 22, 2022

This is ready for review again.

Gudahtt
Gudahtt approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 7c99edd into main Aug 22, 2022
@mcmire mcmire deleted the release/6.0.0 branch August 22, 2022 22:45
@mcmire
Copy link
Contributor

mcmire commented Aug 23, 2022

@Gudahtt This is ready to publish to NPM when you get a chance.

@Gudahtt
Copy link
Member

Gudahtt commented Aug 24, 2022

Published!

A new version of the package eth-block-tracker (6.0.0) was published at 2022-08-24T00:12:17.076Z from
[redacted]. The shasum of this package was 24d9d730f16d1f39fd69b67109fb09d9d3d8e8fb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmire @Gudahtt