Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: bump eslint,jest #156

Merged
merged 8 commits into from
Jul 12, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 10, 2023

CVE-2023-26115

Resolves #137

@socket-security
Copy link

socket-security bot commented Jul 10, 2023

@socket-security
Copy link

socket-security bot commented Jul 10, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @nicolo-ribaudo/semver-v6@6.3.3, builtins@5.0.1, eslint-plugin-n@15.7.0, semver@6.3.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat

This comment was marked as outdated.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 12, 2023
@legobeat legobeat requested a review from mcmire July 12, 2023 08:06
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @nicolo-ribaudo/semver-v6@6.3.3
@SocketSecurity ignore builtins@5.0.1
@SocketSecurity ignore eslint-plugin-n@15.7.0
@SocketSecurity ignore semver@6.3.1

@legobeat legobeat marked this pull request as ready for review July 12, 2023 08:07
@legobeat legobeat requested a review from a team as a code owner July 12, 2023 08:07
src/PollingBlockTracker.ts Outdated Show resolved Hide resolved
@legobeat legobeat requested review from mcmire and a team July 12, 2023 20:03
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit 861683e into MetaMask:main Jul 12, 2023
@legobeat legobeat deleted the devdeps-jest-eslint branch July 12, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to newer versions of ESLint config packages
2 participants