Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Backport fix: init waits for the iframe to be loaded #241

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Aug 27, 2024

This PR backports this fix to the 3.x branch

@mikesposito mikesposito requested a review from a team as a code owner August 27, 2024 09:58
@mikesposito mikesposito changed the title [3.x] Backport iframe init fix [3.x] Backport fix: `init waits for the iframe to be loaded Aug 27, 2024
@mikesposito mikesposito changed the title [3.x] Backport fix: `init waits for the iframe to be loaded [3.x] Backport fix: init waits for the iframe to be loaded Aug 27, 2024
@mikesposito mikesposito changed the title [3.x] Backport fix: init waits for the iframe to be loaded [3.x] Backport fix: init waits for the iframe to be loaded Aug 27, 2024
Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit we are backporting has been cherry-picked without changes - with the exception of this file

@mikesposito mikesposito merged commit f7ba397 into 3.x Aug 27, 2024
17 checks passed
@mikesposito mikesposito deleted the backport-iframe-init-fix branch August 27, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants