Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/afqdn check #6891

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Bugfix/afqdn check #6891

merged 4 commits into from
Mar 22, 2022

Conversation

409H
Copy link
Collaborator

@409H 409H commented Mar 21, 2022 •
edited
Loading

  • Convert absolute fully qualified domain name into fully qualified domain name before running the checks

AlexHerman1
AlexHerman1 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@AlexHerman1 AlexHerman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexHerman1 AlexHerman1 merged commit e58ead2 into master Mar 22, 2022
@AlexHerman1 AlexHerman1 deleted the bugfix/afqdn-check branch March 22, 2022 14:17
@Gudahtt
Copy link
Member

Gudahtt commented Mar 22, 2022

A new version of the package eth-phishing-detect (1.1.16) was published at 2022-03-22T16:29:57.541Z from
[redacted]. The shasum of this package was 637158d5774819e1a861f6d169e6d77d076a47fd.

@409H 409H mentioned this pull request Mar 24, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexHerman1 AlexHerman1 AlexHerman1 approved these changes

@trn1ty trn1ty Awaiting requested review from trn1ty

@ethphishingmaintainer1000 ethphishingmaintainer1000 Awaiting requested review from ethphishingmaintainer1000

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@409H @Gudahtt @AlexHerman1