devDeps: upgrade test & lint suite

[legobeat]

This upgrades test and lint packages, bringing in configuration in direction of https://github.com/MetaMask/metamask-module-template/.

Migrating to jest and fixing jsdoc comments left as separate changes. Otherwise updated linting rules have been applied.

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/anymatch@3.1.3, npm/cosmiconfig@7.1.0, npm/expand-tilde@2.0.2, npm/fast-diff@1.3.0, npm/for-each@0.3.3, npm/global-prefix@1.0.2, npm/hasown@2.0.0, npm/resolve-dir@1.0.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

[legobeat]

@SocketSecurity ignore please-upgrade-node@3.2.0
@SocketSecurity ignore semver-compare@1.0.0

Let's see if they pick up typicode/please-upgrade-node#36

[legobeat]

@SocketSecurity ignore @vue/compiler-sfc@3.3.2
@SocketSecurity ignore cosmiconfig@7.1.0
@SocketSecurity ignore depcheck@1.4.3
@SocketSecurity ignore escalade@3.1.1
@SocketSecurity ignore eslint-module-utils@2.8.0
@SocketSecurity ignore glob@7.2.0
@SocketSecurity ignore locate-path@6.0.0
@SocketSecurity ignore loose-envify@1.4.0
@SocketSecurity ignore argparse@2.0.1
@SocketSecurity ignore error-ex@1.3.2
@SocketSecurity ignore query-ast@1.0.5
@SocketSecurity ignore randombytes@2.1.0
@SocketSecurity ignore scss-parser@1.0.6
@SocketSecurity ignore for-each@0.3.3
@SocketSecurity ignore anymatch@3.1.3
@SocketSecurity ignore fast-diff@1.2.0
@SocketSecurity ignore spdx-exceptions@2.3.0
@SocketSecurity ignore functions-have-names@1.2.3
@SocketSecurity ignore comment-parser@1.3.1
@SocketSecurity ignore globalthis@1.0.3
@SocketSecurity ignore is-weakref@1.0.2
@SocketSecurity ignore supports-preserve-symlinks-flag@1.0.0
@SocketSecurity ignore available-typed-arrays@1.0.5
@SocketSecurity ignore invariant@2.2.4
@SocketSecurity ignore is-arrayish@0.2.1
@SocketSecurity ignore get-symbol-description@1.0.0
@SocketSecurity ignore jsesc@2.5.2
@SocketSecurity ignore is-shared-array-buffer@1.0.2
@SocketSecurity ignore function.prototype.name@1.1.5
@SocketSecurity ignore deps-regex@0.1.4
@SocketSecurity ignore yocto-queue@0.1.0
@SocketSecurity ignore has-tostringtag@1.0.0
@SocketSecurity ignore source-map-js@1.0.2
@SocketSecurity ignore side-channel@1.0.4
@SocketSecurity ignore prettier-linter-helpers@1.0.0
@SocketSecurity ignore @ungap/promise-all-settled@1.1.2
@SocketSecurity ignore picocolors@1.0.0
@SocketSecurity ignore @types/parse-json@4.0.0
@SocketSecurity ignore multimatch@5.0.0
@SocketSecurity ignore require-package-name@2.0.1
@SocketSecurity ignore array-differ@3.0.0
@SocketSecurity ignore lines-and-columns@1.2.4
@SocketSecurity ignore to-fast-properties@2.0.0
@SocketSecurity ignore es-shim-unscopables@1.0.0
@SocketSecurity ignore arrify@2.0.1
@SocketSecurity ignore safe-buffer@5.2.1
@SocketSecurity ignore has-property-descriptors@1.0.0
@SocketSecurity ignore spdx-expression-parse@3.0.1

Many of these look to be eternal until they're removed from entrypoint packages (cf https://github.com/inspect-js/is-typed-array/pull/54#issuecomment-1547171507)

I'm as much for backwards-compat as the next person but with a network of interconnected micropackages all maintained with this approach underpinning the linting, I have a feeling this can get uncomfortable over time.

[legobeat]

Blocked by MetaMask/eslint-config#290

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/code-frame@7.22.13	Transitive: environment	+10	192 kB	nicolo-ribaudo
npm/@babel/parser@7.23.3	None	0	1.89 MB	nicolo-ribaudo
npm/@babel/types@7.23.3	environment	+3	2.49 MB	nicolo-ribaudo
npm/@eslint-community/regexpp@4.10.0	None	0	431 kB	eslint-community-bot
npm/@jridgewell/sourcemap-codec@1.4.15	None	0	45.9 kB	jridgewell
npm/@jridgewell/trace-mapping@0.3.20	None	+1	219 kB	jridgewell
npm/@metamask/eslint-config-mocha@12.1.0	None	0	8.58 kB	metamaskbot
npm/@metamask/eslint-config-nodejs@12.1.0	None	0	94.8 kB	metamaskbot
npm/@metamask/eslint-config-typescript@12.1.0	None	0	18.5 kB	metamaskbot
npm/@metamask/eslint-config@12.2.0	None	0	119 kB	metamaskbot
npm/@nodelib/fs.stat@2.0.5	filesystem	0	11.8 kB	mrmlnc
npm/@nodelib/fs.walk@1.2.8	Transitive: filesystem	+5	107 kB	mrmlnc
npm/@typescript-eslint/eslint-plugin@5.62.0	Transitive: environment, filesystem	+23	6.39 MB	jameshenry
npm/@typescript-eslint/parser@5.62.0	Transitive: environment, filesystem	+13	2.01 MB	jameshenry
npm/call-bind@1.0.5	None	+4	81.5 kB	ljharb
npm/camelcase@6.3.0	None	0	11.7 kB	sindresorhus
npm/debug@4.3.4	environment	0	42.4 kB	qix
npm/define-data-property@1.1.1	None	+2	47.5 kB	ljharb
npm/define-properties@1.2.1	None	+2	50 kB	ljharb
npm/depcheck@1.4.7	filesystem, unsafe Transitive: environment, eval	+61	9.49 MB	rumpl
npm/eslint-config-prettier@8.10.0	None	0	19.9 kB	lydell
npm/eslint-plugin-import@2.26.0	filesystem, unsafe Transitive: environment, network	+63	5.68 MB	ljharb
npm/eslint-plugin-jsdoc@43.2.0	None	+8	2.53 MB	gajus
npm/eslint-plugin-mocha@10.2.0	None	+3	1.24 MB	lo1tuma
npm/eslint-plugin-n@15.7.0	filesystem	+10	1.57 MB	weiran.zsd
npm/eslint-plugin-prettier@4.2.1	None	+2	120 kB	jounqin
npm/eslint-plugin-promise@6.1.1	None	0	67.1 kB	eslint-community-bot
npm/eslint-visitor-keys@3.4.3	None	0	32.3 kB	eslintbot
npm/eslint@8.54.0	environment, filesystem Transitive: eval, shell, unsafe	+56	8.18 MB	eslintbot
npm/espree@9.6.1	None	+2	629 kB	eslintbot
npm/esquery@1.5.0	None	0	1 MB	michaelficarra
npm/expand-tilde@2.0.2	Transitive: environment, filesystem	+2	20.6 kB	doowb
npm/find-up@5.0.0	Transitive: filesystem	+5	43.7 kB	sindresorhus
npm/get-intrinsic@1.2.2	eval	+3	89.4 kB	ljharb
npm/glob@7.2.0	filesystem Transitive: environment	+9	109 kB	isaacs
npm/has-symbols@1.0.3	None	0	20.6 kB	ljharb
npm/ignore@5.3.0	None	0	51.2 kB	kael
npm/is-array-buffer@3.0.2	None	0	11.9 kB	ljharb
npm/is-callable@1.2.7	None	0	28.9 kB	ljharb
npm/is-core-module@2.13.1	None	+2	72.5 kB	ljharb
npm/is-glob@4.0.3	None	+1	19.8 kB	phated
npm/is-string@1.0.7	None	+1	30 kB	ljharb
npm/is-typed-array@1.1.12	None	0	17.6 kB	ljharb
npm/minimist@1.2.8	None	0	54.5 kB	ljharb
npm/mocha@9.2.2	environment, eval, filesystem Transitive: shell	+33	5.55 MB	juergba
npm/object-inspect@1.13.1	None	0	97.2 kB	ljharb
npm/picomatch@2.3.1	None	0	90 kB	mrmlnc
npm/prettier@2.8.8	environment, filesystem, unsafe	0	11.2 MB	prettier-bot
npm/readdirp@3.6.0	filesystem	0	20.5 kB	paulmillr
npm/resolve-dir@1.0.1	Transitive: environment, filesystem	+8	73.1 kB	phated
npm/resolve@1.22.8	environment, filesystem	+2	159 kB	ljharb
npm/string-width@4.2.3	None	+2	58.4 kB	sindresorhus
npm/strip-ansi@6.0.1	None	+1	9.64 kB	sindresorhus
npm/typescript@4.8.4	None	0	68.8 MB	typescript-bot
npm/which-typed-array@1.1.13	None	+4	80.4 kB	ljharb
npm/yargs-parser@20.2.4	environment, filesystem	0	120 kB	oss-bot
npm/yargs@16.2.0	environment, filesystem	+6	379 kB	oss-bot

🚮 Removed packages: npm/@metamask/eslint-config@5.0.0, npm/@nodelib/fs.stat@2.0.4, npm/@typescript-eslint/eslint-plugin@4.17.0, npm/@typescript-eslint/parser@4.17.0, npm/call-bind@1.0.2, npm/debug@4.3.1, npm/define-properties@1.1.3, npm/es-abstract@1.18.0, npm/eslint-plugin-import@2.22.1, npm/eslint-plugin-mocha@8.1.0, npm/eslint-plugin-node@11.1.0, npm/eslint@7.21.0, npm/espree@7.3.1, npm/find-up@3.0.0, npm/get-intrinsic@1.1.1, npm/glob@7.1.3, npm/has-symbols@1.0.2, npm/is-callable@1.2.3, npm/is-glob@4.0.1, npm/is-regex@1.1.2, npm/minimatch@3.0.4, npm/minimist@1.2.7, npm/mocha@7.1.1, npm/object-inspect@1.9.0, npm/object.assign@4.1.2, npm/picomatch@2.2.2, npm/resolve@1.20.0, npm/string.prototype.trimend@1.0.4, npm/string.prototype.trimleft@2.1.2, npm/string.prototype.trimright@2.1.2, npm/string.prototype.trimstart@1.0.4, npm/typescript@4.0.5, npm/yargs-parser@13.1.2, npm/yargs@13.3.2

View full report↗︎

[legobeat]

• Rebased on main
• Bumped depcheck to latest
• Bumped @metamask/eslint* to latest and align peerDeps

[legobeat]

@SocketSecurity ignore npm/anymatch@3.1.3
@SocketSecurity ignore npm/for-each@0.3.3
@SocketSecurity ignore npm/cosmiconfig@7.1.0
@SocketSecurity ignore npm/fast-diff@1.3.0
@SocketSecurity ignore npm/resolve-dir@1.0.1
@SocketSecurity ignore npm/expand-tilde@2.0.2
@SocketSecurity ignore npm/global-prefix@1.0.2
@SocketSecurity ignore npm/hasown@2.0.0

new author ok

[mcmire]

Sorry for the long delay on reviewing this. Obviously we need more work to bring this project up to date with the module template but this is a good start. Good call to delay the JSDoc rules, I agree that this can be its own PR — perhaps we want to remove the dummy comments for now? Otherwise this PR looks good.