Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bn.js@4.11.6->^5.2.1 #12

Merged
merged 3 commits into from
Nov 14, 2023
Merged

deps: bn.js@4.11.6->^5.2.1 #12

merged 3 commits into from
Nov 14, 2023

Conversation

legobeat
Copy link

@legobeat legobeat commented Nov 7, 2023 •
edited
Loading

  • deps: number-to-bn@1.7.0 -> @metamask/number-to-bn@^1.7.1
  • deps: bn.js@4.11.6->^5.2.1

Blocked by

@legobeat legobeat mentioned this pull request Nov 7, 2023
Merged
@socket-security Socket Security
Copy link

socket-security bot commented Nov 7, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/number-to-bn 1.7.1 None +0 292 kB lgbot

@socket-security Socket Security
Copy link

socket-security bot commented Nov 7, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat mentioned this pull request Nov 7, 2023
Merged
1 task
@legobeat legobeat marked this pull request as ready for review November 14, 2023 21:38
mcmire
mcmire approved these changes Nov 14, 2023
View reviewed changes
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It doesn't seem that we are doing anything sufficiently complicated with bn.js, so the bump seems safe.

@legobeat legobeat merged commit 22df709 into MetaMask:main Nov 14, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@naugtur naugtur Awaiting requested review from naugtur

@kumavis kumavis Awaiting requested review from kumavis

@brad-decker brad-decker Awaiting requested review from brad-decker

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire