Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero private key for ed25519 #122

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 6, 2023

0x000...000 is a valid private key for ed25519 (since all private keys are valid). Previously we would always reject this private key, due to the function used to validate bytes. I've updated it to use the curve function to check if a private key is valid.

Related to MM-02-007.

@Mrtenz Mrtenz requested a review from a team as a code owner March 6, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants