Prevent setting gas price below minimum #10519
Comments
leafcutterant
changed the title
|
Thanks for the report! Unfortunately, there is little we can do about this. We don't impose any such restriction. This error comes from Infura, which requires that replacement transactions have a gas price at least 10% higher than the last gas price. See the |
|
Oh. This is annoying. However, what you could do is display a useful error message instead of this garbled text, so people can act on it. How about:
where X% is queried from Infura and Y is calculated from X% and the previous gas price. |
|
Yes, that's a good point! This error isn't very informative. How did you encounter this error by the way? Did you see this error in a dapp after suggesting a transaction with too low of a gas price? Or was this seen on the confirmation UI, or in the send flow? |
|
The error was displayed as a Metamask notification pop-up after I approved the transaction from MM. I got it after manually setting a new, higher gas price for a transaction I previously sent. |
|
Hey, how about querying Would you consider renaming the issue accordingly and reopen it? |
|
Certainly! That sounds reasonable |
Gudahtt
changed the title
bschorchit
added
area-transactions
team-confirmations-secure-ux
hilvmason
added
team-confirmations-planning
## **Description** Our fork of ethjs-query has been namespaced to the `@metamask/` namespace, and updated with mostly development only fixes. There is one exception which is the reason for this pull request which is the removal of a try/catch that was catching too broadly and wrapping legitimate errors in a new Error object that claimed the issue was with the formatting of the output. In most cases this is incorrect and results in a wide swath of errors being lumped together inside of sentry. This change will result in the real errors being surfaced, after which we can decide where to prioritize efforts to resolve RPC issues. This PR progresses, and is expected to change the stack trace for the following issues: #9317 #10519 #10619 #11488 #11974 #13395 #14298 #14365 #15250 #17073 #17803 #19697 #20699 We are closing these issues opened automatically by sentry-io which are not fully resolved but should result in better errors and stack traces: fixes #10552 fixes #14660 fixes #14676 fixes #14730 fixes #14801 fixes #15065 ## **Manual testing steps** 1. Attempt to reproduce any of the bugs listed, 17073 was the easiest to reproduce for me. This involves getting test currency from the wemix faucet as listed in the issue and initiating a transaction between two accounts you own. 2. On develop you'll see an 'error formatting outputs' error text similar to what is reported in the issue. 3. On this branch you'll get the original error, without the wrapped 'formatting' error. including a different stack trace. ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
We should query
txpool.pricebumpfrom the current network and disallow setting a new gas price that falls below that. This way users wouldn't even get to the point of trying to submit a transaction with a gas price below the minimum (which will be certainly rejected).Original issue description (see discussion below for edit reason):
Somewhat related to #9317, in that the way to reproduce is the same, only the error message is now different:
Transaction N failed! Error: [ethjs-rpc] while formatting outputs from RPC '{"value":{"code":-32000, "message":"replacement transaction underpriced"}}'Stop making decisions instead of the user on what gas price is allowed. If I want to speed up by only adding 10 Gwei to the original, and I'm fine with my transaction confirming within 48 hours, then let me do it.
The text was updated successfully, but these errors were encountered: