Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time-limit retry attempts #40

Closed
danfinlay opened this issue Mar 8, 2016 · 1 comment
Closed

Time-limit retry attempts #40

danfinlay opened this issue Mar 8, 2016 · 1 comment

Comments

@danfinlay
Copy link
Contributor

danfinlay commented Mar 8, 2016

At least for the public launch, we should have a background-enforced time-limiting on password retries, to reduce plausibility of brute forcing a metamask vault. Maybe the retry interval should increase logarithmically, too.

@danfinlay danfinlay added this to the 3 Public Launch milestone Mar 8, 2016
@kumavis
Copy link
Member

kumavis commented Mar 9, 2016

this should be done at the crypto level by deriving the privatekey via a time-intensive hash bc if you have access to the computer you can just grab the encrypted lightwallet data from localstorage and brute force it back in your evil crypto lair

@danfinlay danfinlay added ready and removed ready labels Mar 31, 2016
SeungjunWe pushed a commit to DcentWallet/metamask-extension that referenced this issue Jul 13, 2020
danjm added a commit that referenced this issue Oct 6, 2020
* Remove unnecessary default values in FeeCard component

Add gas customization link to fee card on view quote screen (#40)

* Add max gas row to fee card on view quote screen

* Add approve edit limit support to swaps (#41)

* Update transaction list to support swaps (#42)

Co-authored-by: Erik Marks <rekmarks@protonmail.com>
danjm added a commit that referenced this issue Oct 6, 2020
* Styling and UX improvements to various swaps components

Remove unnecessary default values in FeeCard component

Add gas customization link to fee card on view quote screen (#40)

Add max gas row to fee card on view quote screen

Add approve edit limit support to swaps (#41)

Update transaction list to support swaps (#42)

Update FeeCard props, stories (#53)

Co-authored-by: Dan Miller <danjm.com@gmail.com>
danjm added a commit that referenced this issue Oct 6, 2020
* Remove unnecessary default values in FeeCard component

Add gas customization link to fee card on view quote screen (#40)

* Add max gas row to fee card on view quote screen

* Add approve edit limit support to swaps (#41)

* Update transaction list to support swaps (#42)

Co-authored-by: Erik Marks <rekmarks@protonmail.com>
danjm added a commit that referenced this issue Oct 6, 2020
* Styling and UX improvements to various swaps components

Remove unnecessary default values in FeeCard component

Add gas customization link to fee card on view quote screen (#40)

Add max gas row to fee card on view quote screen

Add approve edit limit support to swaps (#41)

Update transaction list to support swaps (#42)

Update FeeCard props, stories (#53)

Co-authored-by: Dan Miller <danjm.com@gmail.com>
aloisklink pushed a commit to aloisklink/metamask-extension that referenced this issue Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants