-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time-limit retry attempts #40
Labels
Milestone
Comments
this should be done at the crypto level by deriving the privatekey via a time-intensive hash bc if you have access to the computer you can just grab the encrypted lightwallet data from localstorage and brute force it back in your evil crypto lair |
SeungjunWe
pushed a commit
to DcentWallet/metamask-extension
that referenced
this issue
Jul 13, 2020
Add tests for token removal
danjm
added a commit
that referenced
this issue
Oct 6, 2020
* Remove unnecessary default values in FeeCard component Add gas customization link to fee card on view quote screen (#40) * Add max gas row to fee card on view quote screen * Add approve edit limit support to swaps (#41) * Update transaction list to support swaps (#42) Co-authored-by: Erik Marks <rekmarks@protonmail.com>
danjm
added a commit
that referenced
this issue
Oct 6, 2020
* Styling and UX improvements to various swaps components Remove unnecessary default values in FeeCard component Add gas customization link to fee card on view quote screen (#40) Add max gas row to fee card on view quote screen Add approve edit limit support to swaps (#41) Update transaction list to support swaps (#42) Update FeeCard props, stories (#53) Co-authored-by: Dan Miller <danjm.com@gmail.com>
danjm
added a commit
that referenced
this issue
Oct 6, 2020
* Remove unnecessary default values in FeeCard component Add gas customization link to fee card on view quote screen (#40) * Add max gas row to fee card on view quote screen * Add approve edit limit support to swaps (#41) * Update transaction list to support swaps (#42) Co-authored-by: Erik Marks <rekmarks@protonmail.com>
danjm
added a commit
that referenced
this issue
Oct 6, 2020
* Styling and UX improvements to various swaps components Remove unnecessary default values in FeeCard component Add gas customization link to fee card on view quote screen (#40) Add max gas row to fee card on view quote screen Add approve edit limit support to swaps (#41) Update transaction list to support swaps (#42) Update FeeCard props, stories (#53) Co-authored-by: Dan Miller <danjm.com@gmail.com>
aloisklink
pushed a commit
to aloisklink/metamask-extension
that referenced
this issue
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At least for the public launch, we should have a background-enforced time-limiting on password retries, to reduce plausibility of brute forcing a metamask vault. Maybe the retry interval should increase logarithmically, too.
The text was updated successfully, but these errors were encountered: