Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info to help page #44

Closed
danfinlay opened this issue Mar 9, 2016 · 0 comments
Closed

Add info to help page #44

danfinlay opened this issue Mar 9, 2016 · 0 comments
Assignees
@danfinlay
Labels
type-enhancement
Milestone
SXSW Hackathon

Comments

@danfinlay
Copy link
Contributor

We have a ? button in the corner but it goes nowhere.

It should go to a help page that includes

  • join slack
  • public github issues
  • email

Where do we want to keep public github issues, @kumavis?
@danfinlay danfinlay self-assigned this Mar 9, 2016
@danfinlay danfinlay added this to the SXSW Hackathon milestone Mar 9, 2016
@danfinlay danfinlay mentioned this issue Mar 9, 2016
Merged
@kumavis kumavis closed this as completed Mar 9, 2016
danjm pushed a commit that referenced this issue Dec 20, 2019
@rekmarks
Update plugin reinstall behavior, fix permission-related bugs, variou…
3a741e0 
…s minor changes (#44)

* overwrite plugins on reinstall

* fix various perm bugs

* cleanup and bugfixes
yqrashawn added a commit to yqrashawn/conflux-portal that referenced this issue Feb 17, 2020
@yqrashawn
Merge pull request MetaMask#44 from Conflux-Chain/master
8fba009 
Master => develop
danjm pushed a commit that referenced this issue Oct 6, 2020
@Gudahtt @danjm
Remove unused state from swaps Redux store (#44)
9f17694 
These portions of state were never read.

* `swapsTokens` and `tradeTxId` were never read, and the action
creators to set them were nevercalled.
* `quotes` was present only in the initial state, and was never read or
written.

The `swapsQuotesFetchStartTime` state was also never read, but it is
used in a subsequent PR.
danjm pushed a commit that referenced this issue Oct 6, 2020
@Gudahtt @danjm
Remove unused state from swaps Redux store (#44)
0746774 
These portions of state were never read.

* `swapsTokens` and `tradeTxId` were never read, and the action
creators to set them were nevercalled.
* `quotes` was present only in the initial state, and was never read or
written.

The `swapsQuotesFetchStartTime` state was also never read, but it is
used in a subsequent PR.
This was referenced Jan 19, 2021
Open
Open
aloisklink pushed a commit to aloisklink/metamask-extension that referenced this issue Jan 19, 2022
@whymarrh
Use strict assert (MetaMask#44)
fb29d0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danfinlay danfinlay

Labels
type-enhancement
Projects
None yet
Milestone
SXSW Hackathon
Development

No branches or pull requests
3 participants
@danfinlay @kumavis @2-am-zzz