Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor account-details-modal.js #6741

Closed
danjm opened this issue Jun 21, 2019 · 1 comment · Fixed by #6751
Closed

Refactor account-details-modal.js #6741

danjm opened this issue Jun 21, 2019 · 1 comment · Fixed by #6751
Assignees
@Gudahtt @danjm
Labels
area-UI Relating to the user interface. type-refactor
Milestone
UI Sprint 15 [Jun...

Comments

@danjm
Copy link
Contributor

danjm commented Jun 21, 2019 •
edited
Loading

The file can be found at metamask-extension/ui/app/components/app/modals/account-details-modal.js

This component can be found within the app by clicking the "Details" button on the left side of the home screen. See below:

Peek 2019-06-24 13-01

This task is to make the following improvements to the code:

  • move the component to its own directory with index.js, account-details-modal.component.js and account-details-modal.container.js files
  • account-details-modal.container.js should be a redux "container component". The purpose is to connect account-details-modal.component.js to redux using the react-redux library. See metamask-extension/ui/app/components/app/app-header/app-header.container.js for an example
  • account-details-modal.component.js should contain the component class and its methods, but there will be no connection to redux within that file
  • rewrite the component with jsx, eliminating the use of hyperscript
  • feel free to make any other changes you think are necessary
@danjm danjm added type-refactor area-UI Relating to the user interface. labels Jun 21, 2019
@danjm danjm self-assigned this Jun 21, 2019
@whymarrh
Copy link
Contributor

@danjm I don't believe the attached GIF is correct for this issue

@Gudahtt Gudahtt self-assigned this Jun 24, 2019
@Gudahtt Gudahtt mentioned this issue Jun 25, 2019
Merged
Gudahtt added a commit to Gudahtt/metamask-extension that referenced this issue Jun 25, 2019
@Gudahtt
Refactor account-details-modal
8b83b1c 
Refactor the AccountDetailsModal to follow newer conventions. Changes
include:
- Create a directory for the component with separate files for the
  component, the container, and the entrypoint.
- Use jsx rather than hyperscript

Fixes MetaMask#6741
Gudahtt added a commit that referenced this issue Jun 27, 2019
@Gudahtt
Refactor account-details-modal (#6751)
6d191f2 
Refactor the AccountDetailsModal to follow newer conventions. Changes
include:
- Create a directory for the component with separate files for the
  component, the container, and the entrypoint.
- Use jsx rather than hyperscript

Fixes #6741
@danfinlay danfinlay mentioned this issue Jul 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gudahtt Gudahtt

@danjm danjm

Labels
area-UI Relating to the user interface. type-refactor
Projects
None yet
Milestone
UI Sprint 15 [June 24]
Development

Successfully merging a pull request may close this issue.

Refactor account-details-modal Gudahtt/metamask-extension
3 participants
@whymarrh @Gudahtt @danjm