Ensure permissions log only stores JSON-able data #10524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the permissions log will only store JSON-able data. I encountered this problem will building for snaps. This is unlikely, probably even impossible, to occur on
develop
at the moment, but the fix is cheap. It's accomplished as follows:fast-safe-stringify
fast-safe-stringify
as production dependencyeth-rpc-errors
and probably othersAdditionally, makes the following related but distinct change:
safe-json-stringify
from production dependenciesfast-safe-stringify
, the latter appears to be more widely used, and will remain our dependency graph regardless. Removingsafe-json-stringify
as a direct dependency removed it from our lockfile.