Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no more node:console #10640

Merged
merged 1 commit into from
Mar 12, 2021
Merged

no more node:console #10640

merged 1 commit into from
Mar 12, 2021

Conversation

brad-decker
Copy link
Contributor

Make vscode stop auto importing node:console when autocompleting 'console'.

@brad-decker brad-decker requested a review from a team as a code owner March 12, 2021 19:21
@brad-decker brad-decker requested a review from ryanml March 12, 2021 19:21
rekmarks
rekmarks approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vry cool

@metamaskbot
Copy link
Collaborator

Builds ready [affa4f6]
Page Load Metrics (572 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint458060105
domContentLoaded33987957112158
load34088057212158
domInteractive33987957112158

@brad-decker brad-decker merged commit 661948c into develop Mar 12, 2021
@brad-decker brad-decker deleted the no-more-node-console-import branch March 12, 2021 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brad-decker @metamaskbot @rekmarks