Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing migration script generation paths #10664

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fixing migration script generation paths #10664

merged 1 commit into from
Mar 17, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 17, 2021

Testing paths were updated via: #10655

development/generate-migration.sh was not updated to use the new paths and formatting to generate the migration scripts.

Manual testing steps:

  • yarn generate:migration n (where the last migration id + 1)
  • Ensure migration file and test file are correctly created

@ryanml ryanml self-assigned this Mar 17, 2021
@ryanml ryanml requested review from kumavis and a team as code owners March 17, 2021 04:06
@metamaskbot
Copy link
Collaborator

Builds ready [6dec5b9]
Page Load Metrics (553 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44655373
domContentLoaded3726375517536
load3746425537536
domInteractive3726365517536

@kumavis
Copy link
Member

kumavis commented Mar 17, 2021

Nice catch

@kumavis kumavis merged commit 88ad383 into develop Mar 17, 2021
@kumavis kumavis deleted the migration-fix branch March 17, 2021 04:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants