Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the correct default currency symbols are used for fees on the view quote screen #10753

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Mar 29, 2021

This PR fixes an issues found by @tmashuang while reviewing v9.3.0

It ensures that fees on the view quote screen - in both the fees card and in the gas modal - use the correct currency symbol. On mainnet this will be ETH. On custom networks, this will be the currency symbol set by the user, or if no currency symbol has been set, it will be the symbol of the default token for that network.

Demo video is here: https://www.veed.io/download/a2f4f25e-f0b6-4658-8909-4f48730f1890

@danjm danjm requested a review from a team as a code owner March 29, 2021 14:40
@danjm danjm requested a review from darkwing March 29, 2021 14:40
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm force-pushed the use-correct-chain-symbols-swaps-view-quote branch from 8912c6d to 42d2ece Compare March 29, 2021 14:47
@metamaskbot
Copy link
Collaborator

Builds ready [42d2ece]
Page Load Metrics (617 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint448756105
domContentLoaded3528306159445
load3538316179445
domInteractive3528306159445

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danjm danjm merged commit 76f4e93 into develop Mar 29, 2021
@danjm danjm deleted the use-correct-chain-symbols-swaps-view-quote branch March 29, 2021 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants