Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only applies rules to the appropriate files #10788

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

brad-decker
Copy link
Contributor

Previously the mocha rules were disabled for anything without the .test.js suffix, which unfortunately included the .spec.js files in E2E folder. This update aims to simplify overrides for tests by only extending the mocha configuration for files that need it.

Also, this change now only applies react rules to the UI folder.

@metamaskbot
Copy link
Collaborator

Builds ready [806a0cb]
Page Load Metrics (640 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50695963
domContentLoaded35882663810249
load36082764010249
domInteractive35882563810249

@brad-decker brad-decker marked this pull request as ready for review April 1, 2021 14:23
@brad-decker brad-decker requested a review from a team as a code owner April 1, 2021 14:23
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 7b0a25c into develop Apr 1, 2021
@brad-decker brad-decker deleted the make-rules-specific branch April 1, 2021 18:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants