Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade eslint deps #10789

Merged
merged 1 commit into from
Apr 1, 2021
Merged

upgrade eslint deps #10789

merged 1 commit into from
Apr 1, 2021

Conversation

brad-decker
Copy link
Contributor

Upgrade eslint dependencies to improve lint performance and accuracy. Fixes one new warning from react hooks rules.

@metamaskbot
Copy link
Collaborator

Builds ready [b06e422]
Page Load Metrics (595 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50745974
domContentLoaded3677145937938
load3697145957938
domInteractive3677135937938

@brad-decker brad-decker marked this pull request as ready for review April 1, 2021 14:23
@brad-decker brad-decker requested a review from a team as a code owner April 1, 2021 14:23
@brad-decker brad-decker requested a review from ryanml April 1, 2021 14:23
Gudahtt
Gudahtt approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 1e44c34 into develop Apr 1, 2021
@brad-decker brad-decker deleted the upgrade-eslint-deps branch April 1, 2021 18:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brad-decker @metamaskbot @Gudahtt