Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove script for creating master sync PR #10791

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Remove script for creating master sync PR #10791

merged 1 commit into from
Mar 31, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 31, 2021

The script responsible for creating the "Sync master with develop" PR has been removed. We will soon be eliminating the need for a master branch altogether, so we don't need this anymore. Also, this script hasn't been running correctly in a long time. We've been creating this PR manually.

@Gudahtt
Remove script for creating master sync PR
bd00b59 
The script responsible for creating the "Sync `master` with `develop`"
PR has been removed. We will soon be eliminating the need for a
`master` branch altogether, so we don't need this anymore. Also, this
script hasn't been running correctly in a long time. We've been
creating this PR manually.
@Gudahtt Gudahtt requested review from kumavis and a team as code owners March 31, 2021 22:06
@Gudahtt Gudahtt requested a review from shanejonas March 31, 2021 22:06
ryanml
ryanml approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@metamaskbot
Copy link
Collaborator

Builds ready [bd00b59]
Page Load Metrics (644 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint52766273
domContentLoaded36678264311857
load36878364411857
domInteractive36678264211857

@Gudahtt Gudahtt merged commit 358fec0 into develop Mar 31, 2021
@Gudahtt Gudahtt deleted the remove-master-sync-script branch March 31, 2021 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@shanejonas shanejonas Awaiting requested review from shanejonas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @ryanml