remove node-sass dependency

[brad-decker]

Back in #10208 I changed us over to using dart-sass instead of node-sass, but gulp-sass had a dependency on node-sass that still required it in our build. This change uses gulp-dart-sass to remove that element.

[brad-decker]

Do i need to just delete the patch file to get prep-deps passing? also there are lavamoat policies for node-sass that should be removed but wanted to get a thumbs up / greenlight before doing that @kumavis / @EtDu

[Gudahtt]

@brad-decker Instructions on how to manage lavamoat policies and allow-scripts configuration are here: https://github.com/MetaMask/metamask-extension#changing-dependencies

And yes, deleting the patch would be the correct approach. That reminds me - we don't document how to deal with patches yet 🤔 I should address that.

[brad-decker]

Erg... the policy file changes made me look at bundles

https://bundlephobia.com/result?p=gulp-dart-sass@1.0.2 vs https://bundlephobia.com/result?p=gulp-sass@4.1.0

2.2mb minified vs 141kb minified... I'm thinking we just keep node-sass around for a while.

edit: Well, it's mostly sass which we already include. shrug

[Gudahtt]

That is misleading because of node-sass, which downloads a binary as part of the install script I think? Thus hiding the true size.

Plus the bulk of the size of the dart package is due to the sass package, which we already have in our dependency tree. I do think this would be a strict reduction in our dependencies.

[metamaskbot]

Builds ready [41e4529]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts

Page Load Metrics (591 ± 28 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	44	83	59	10	5
		domContentLoaded	361	641	589	58	28
		load	362	642	591	57	28
		domInteractive	360	641	589	58	28

[kumavis]

looks good. huge yarn-lock reduction 👀 👍

[Gudahtt]

I have just rebased this to fix the yarn.lock conflict. It resolved itself automatically after rebasing and running yarn setup.

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [da4952d]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• build viz: Build System
• code coverage: Report
• storybook: Storybook
• all artifacts

Page Load Metrics (642 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	45	93	59	12	6
		domContentLoaded	407	1087	640	137	66
		load	408	1089	642	137	66
		domInteractive	407	1087	640	137	66