Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring address-book.spec.js to use fixtures #10804

Merged
merged 2 commits into from
Apr 3, 2021

Conversation

NiranjanaBinoy
Copy link
Contributor

Fixes: #10798

Explanation:

  • Moved the file to test/e2e/tests
  • The address-book.spec.js has 2 it parts first part adds a new address and second uses an existing address entry, first one is re-using imported-account and a new state.json is added to test/e2e/fixtures/address-entry which is used in the second scenario.
  • Updated run-all.sh to use the new test file.

@NiranjanaBinoy NiranjanaBinoy self-assigned this Apr 2, 2021
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner April 2, 2021 00:34
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e41d47c]
Page Load Metrics (550 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint448157105
domContentLoaded34768554910249
load34968655010349
domInteractive34768554910249

@metamaskbot
Copy link
Collaborator

Builds ready [29d47dd]
Page Load Metrics (550 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45675473
domContentLoaded3196285489747
load3206295509747
domInteractive3196275489747

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like where you chose to split the tests up, that worked out well

@NiranjanaBinoy NiranjanaBinoy merged commit 044949f into develop Apr 3, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the e2e-fixtures-address-book branch April 3, 2021 02:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor address-book.spec.js to follow pattern in metamask-extension/test/e2e/tests
3 participants