Fix _getPermittedAccounts type safety #10819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PermissionsController._getPermittedAccounts
could return an array ornull
, but it was used inremoveAllAccountPermissions
as though it could only return an array.I don't believe it would ever return anything other than an array as things stand, but it's not type safe, and we should fix it. Things with
getAccounts
in the name tend to only return arrays in our codebase, so I made_getPermittedAccounts
only return arrays, and updated calls expectingnull
to expect an empty array instead.