Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use one segment instance #10915

Merged
merged 1 commit into from
Apr 26, 2021
Merged

use one segment instance #10915

merged 1 commit into from
Apr 26, 2021

Conversation

brad-decker
Copy link
Contributor

Fixes: no longer splitting analytics into two mixpanels to separate old analytics schema from new, work in progress one. Instead, we will segment in mixpanel to keep visualizations separate.

@metamaskbot
Copy link
Collaborator

Builds ready [686c6a3]
Page Load Metrics (698 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47127692110
domContentLoaded393111969720096
load395112169820096
domInteractive393111969720096

@brad-decker brad-decker force-pushed the one-mixpanel-to-rule-them-all branch from 686c6a3 to bfd75cf Compare April 23, 2021 16:20
@metamaskbot
Copy link
Collaborator

Builds ready [bfd75cf]
Page Load Metrics (689 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint519966136
domContentLoaded4118026888842
load4128036898842
domInteractive4118026878842

@brad-decker brad-decker marked this pull request as ready for review April 23, 2021 17:35
@brad-decker brad-decker requested a review from a team as a code owner April 23, 2021 17:35
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works for me!

@brad-decker brad-decker merged commit f1825e8 into develop Apr 26, 2021
@brad-decker brad-decker deleted the one-mixpanel-to-rule-them-all branch April 26, 2021 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants