Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring incremental-security.spec.js to use fixtures #10917

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Refactoring incremental-security.spec.js to use fixtures #10917

merged 4 commits into from
Apr 26, 2021

Conversation

NiranjanaBinoy
Copy link
Contributor

Fixes: #10916

Explanation:

  • Moved the file to test/e2e/tests
  • Updated helper.js to start the sendwithprivatedapp
  • Updated incremental-security.spec.js to use fixtures.
  • Updated run-all.sh to use the new test file.
  • Deleted the old incremental-security.spec.js file

@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner April 23, 2021 17:57
@NiranjanaBinoy NiranjanaBinoy self-assigned this Apr 23, 2021
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [45e3e91]
Page Load Metrics (565 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44695773
domContentLoaded3826565648943
load3846575658842
domInteractive3826565638943

@NiranjanaBinoy NiranjanaBinoy force-pushed the e2e-fictures-incremental-security branch from 45e3e91 to 5f74f21 Compare April 23, 2021 23:11
@metamaskbot
Copy link
Collaborator

Builds ready [5f74f21]
Page Load Metrics (581 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint447756105
domContentLoaded35673357910952
load35873458110952
domInteractive35673357910952

@SirJosh1987

This comment has been minimized.

Sign in to view
@ha842

This comment has been minimized.

Sign in to view
brad-decker
brad-decker previously approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@metamaskbot
Copy link
Collaborator

Builds ready [2a0b644]
Page Load Metrics (589 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint458859115
domContentLoaded3876815889546
load3886825899546
domInteractive3866815889546

brad-decker
brad-decker approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NiranjanaBinoy NiranjanaBinoy merged commit d97a9e8 into develop Apr 26, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the e2e-fictures-incremental-security branch April 26, 2021 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brad-decker brad-decker brad-decker approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor incremental-security.spec.js to follow pattern in metamask-extension/test/e2e/tests
5 participants
@NiranjanaBinoy @metamaskbot @SirJosh1987 @ha842 @brad-decker