Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add view account-details menu item to token-options menu #10932

Merged

Conversation

adonesky1
Copy link
Contributor

(partially) Fixes: #10148

Explanation: Adds the Account Details menu item/link to the hamburger menu on token pages

Manual testing steps:

  • Navigate to a token page (other than Eth)
  • Click the hamburger/meatball menu in the top right hand corner
  • Confirm that there is an Account Details menu item available and that when clicked it pops the correct modal.

@adonesky1 adonesky1 requested a review from a team as a code owner April 26, 2021 21:08
@adonesky1 adonesky1 requested a review from ryanml April 26, 2021 21:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1
Copy link
Contributor Author

@danjm Just want to highlight here there are segment events that are raised by the click handlers of the base account level menu items. Not sure if there is an existing issue to port those over to these asset-level menus, but if not I'm happy to write one up?

brad-decker
brad-decker previously approved these changes Apr 26, 2021
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could probably just invoke dispatch(showModal directly from the token-options component but given these two files are already linked tightly it doesn't matter and your contribution matches what is already happening so I think we should land it as is.

@brad-decker
Copy link
Contributor

Oops missed the proptypes. Just need to update those and I think this can land

@adonesky1 adonesky1 merged commit 5bde528 into MetaMask:develop Apr 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "account details" to hamburger menu in asset view
2 participants