Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing alignment issue with bottom notification #10979

Merged
merged 1 commit into from
May 3, 2021
Merged

Fixing alignment issue with bottom notification #10979

merged 1 commit into from
May 3, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 3, 2021

align-items: left; is invalid, and align-items: center; on the notification container was producing an undesired result, the notifications will align appropriately to the left without it.

Before
Screen Shot 2021-05-03 at 2 03 19 PM

After
Screen Shot 2021-05-03 at 2 04 55 PM

@ryanml ryanml requested review from danjm and tmashuang May 3, 2021 21:09
@ryanml ryanml self-assigned this May 3, 2021
@ryanml ryanml requested a review from a team as a code owner May 3, 2021 21:09
@metamaskbot
Copy link
Collaborator

Builds ready [07fbc76]
Page Load Metrics (669 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint52866694
domContentLoaded38987966812158
load39188066912158
domInteractive38987866712158

tmashuang
tmashuang approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 9e8141e into develop May 3, 2021
@ryanml ryanml deleted the notification-alignment-fix branch May 3, 2021 22:10
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@danjm danjm danjm approved these changes

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanml @metamaskbot @danjm @tmashuang