Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks #11615

danjm · 2021-07-26T13:37:25Z

This PR ensures that transactions created by dapps will work correctly, on both EIP1559 compatible networks and on networks without compatibility, and both for txes with dapp suggested fees and txes where the dapp does not suggest the fee. It also ensures that if we are on an EIP1559 network, and our request for gas fee estimates fails and so we have to fall back to a eth_gasPrice call, that those estimates are handled correctly as well.

eth_gasPrice estimates on an EIP-1559 network are to be set to the maxFeePerGas and the maxPriorityFeePerGas

For testing, it is recommended to use this branch: MetaMask/test-dapp#119

(I will add some demo videos here a bit later)

To do:

Remove controllers version bump, only included here for QA purposes
Needs a rebase

github-actions · 2021-07-26T13:37:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

darkwing

This is excellent Dan! Thank you so much!

metamaskbot · 2021-07-27T19:33:17Z

Builds ready [503d625]

builds: chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: 0
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (638 ± 25 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	51	80	63	8	4
		domContentLoaded	533	749	637	52	25
		load	534	750	638	52	25
		domInteractive	533	749	636	52	25

metamaskbot · 2021-07-27T21:29:23Z

Builds ready [8782855]

builds: chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: 0
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (712 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	54	85	68	9	4
		domContentLoaded	599	884	711	91	44
		load	600	885	712	92	44
		domInteractive	599	884	710	91	44

metamaskbot · 2021-07-28T21:03:51Z

Builds ready [982aa55]

builds: chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: 0
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (690 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	80	67	7	3
		domContentLoaded	617	836	689	60	29
		load	618	844	690	61	29
		domInteractive	616	836	689	60	29

metamaskbot · 2021-07-28T23:57:59Z

Builds ready [0ce50e8]

builds: chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: 0
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (632 ± 23 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	49	88	65	9	5
		domContentLoaded	551	792	630	47	22
		load	552	803	632	48	23
		domInteractive	551	792	630	47	22

danjm · 2021-07-29T17:48:34Z

ui/pages/confirm-transaction-base/confirm-transaction-base.component.js

@@ -449,11 +451,13 @@ export default class ConfirmTransactionBase extends Component {
                    />,
                  ])}
                  subTitle={
-                    <GasTiming


This actually doesn't need to happen in this PR and will be removed when I correctly rebase. But It is okay to have it here for now, so that the error it throws in not a distraction for QA. It has been fixed properly on another PR that will soon be merged

Remove change after rebasing onto develop

Remove console.log in send duck

… all new gas fee estimate types

…twork

…timate api fails

metamaskbot · 2021-07-29T21:41:33Z

Builds ready [742622f]

builds: chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: 0
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5

Page Load Metrics (682 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	56	83	67	9	4
		domContentLoaded	554	843	680	76	36
		load	555	845	682	76	36
		domInteractive	553	842	679	76	36

PeterYinusa · 2021-07-29T21:43:07Z

LGTM!

danjm requested a review from a team as a code owner July 26, 2021 13:37

danjm requested review from PeterYinusa and removed request for a team July 26, 2021 13:37

darkwing approved these changes Jul 26, 2021

View reviewed changes

danjm mentioned this pull request Jul 27, 2021

EIP-1559 - Restore custom values in Edit Gas Popover #11589

Merged

2 tasks

danjm force-pushed the send-flow-eip-1559 branch from 04caeb9 to 266d26b Compare July 27, 2021 15:30

danjm force-pushed the eip1559-improved-txcontroller-support branch from 69e56c4 to 3d89cc0 Compare July 27, 2021 15:31

darkwing added the EIP-1559 Tasks required to complete 1559 support label Jul 28, 2021

danjm force-pushed the eip1559-improved-txcontroller-support branch from cbc3cad to 982aa55 Compare July 28, 2021 20:45

danjm force-pushed the send-flow-eip-1559 branch from 0b24e29 to 8c4cf15 Compare July 29, 2021 11:24

danjm force-pushed the eip1559-improved-txcontroller-support branch from 0ce50e8 to a7e4c10 Compare July 29, 2021 16:30

danjm commented Jul 29, 2021

View reviewed changes

danjm changed the title ~~Update addTxGasDefaults and _getDefaultGasFees to work correctly with all new gas fee estimate types~~ Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks Jul 29, 2021

danjm force-pushed the send-flow-eip-1559 branch 2 times, most recently from b4e8981 to a1e030d Compare July 29, 2021 19:53

danjm force-pushed the eip1559-improved-txcontroller-support branch from a7e4c10 to e0c9eec Compare July 29, 2021 19:56

danjm force-pushed the send-flow-eip-1559 branch from a1e030d to 5aad984 Compare July 29, 2021 19:59

brad-decker and others added 7 commits July 29, 2021 17:30

Fix typo

93cf7ec

Remove console.log in send duck

Update addTxGasDefaults and _getDefaultGasFees to work correctly with…

7d125ea

… all new gas fee estimate types

Don't show gas timing support when not on eip1559 compatible network

0f95edf

Hide gas timing component on transaction screen when on a non-1559 ne…

680d765

…twork

Improve comments, tests and edge case handling

efea66b

Ensure eip1559 fees are applied and updated correctly when eip1559 es…

5debc08

…timate api fails

Lint fix

742622f

danjm force-pushed the eip1559-improved-txcontroller-support branch from e0c9eec to 742622f Compare July 29, 2021 20:20

danjm merged commit df041cf into send-flow-eip-1559 Jul 29, 2021

danjm deleted the eip1559-improved-txcontroller-support branch July 29, 2021 21:44

github-actions bot locked and limited conversation to collaborators Jul 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks #11615

Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks #11615

danjm commented Jul 26, 2021 •

edited

Loading

github-actions bot commented Jul 26, 2021

darkwing left a comment

metamaskbot commented Jul 27, 2021

metamaskbot commented Jul 27, 2021

metamaskbot commented Jul 28, 2021

metamaskbot commented Jul 28, 2021

danjm Jul 29, 2021

metamaskbot commented Jul 29, 2021

PeterYinusa commented Jul 29, 2021

Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks #11615

Update addTxGasDefaults and _getDefaultGasFees to work with new estimate types, and ensure we correctly handle gas price estimates when on EIP1559 networks #11615

Conversation

danjm commented Jul 26, 2021 • edited Loading

github-actions bot commented Jul 26, 2021

darkwing left a comment

Choose a reason for hiding this comment

metamaskbot commented Jul 27, 2021

metamaskbot commented Jul 27, 2021

metamaskbot commented Jul 28, 2021

metamaskbot commented Jul 28, 2021

danjm Jul 29, 2021

Choose a reason for hiding this comment

metamaskbot commented Jul 29, 2021

PeterYinusa commented Jul 29, 2021

danjm commented Jul 26, 2021 •

edited

Loading