Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e to not check for X when running locally #12043

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Sep 8, 2021

The X server check was only added to make Chrome tests run successfully
on CI.

The X server check was only added to make Chrome tests run successfully
on CI.
@mcmire mcmire requested a review from a team as a code owner September 8, 2021 17:05
@mcmire mcmire requested a review from danjm September 8, 2021 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mcmire
Copy link
Contributor Author

mcmire commented Sep 8, 2021

This is a dev fix, so if you can run some or all of Chrome e2e tests locally then this should be good to go.

@metamaskbot
Copy link
Collaborator

Builds ready [b42127c]
Page Load Metrics (506 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37172650311053
domContentLoaded36171748711555
load38072850611254
domInteractive36171748711555

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmire mcmire merged commit 72617d7 into develop Sep 8, 2021
@mcmire mcmire deleted the scope-x-server-check-to-ci branch September 8, 2021 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants